Maintainer Policy

Breaking any of these rules may result in an instant demotion from Maintainer.

General

Maintainers are expected to communicate respectfully with each other and with contributors in GitHub and Discord, to a reasonable extent. Engaging in harassment campaigns or attempting to stir up drama for no good reason may result in instant demotion from Maintainer.

Reviews and Merging PRs

This does not apply to PRs by Head Maintainers or Head Game Admins.

Procedure: Every PR must have at least one Head Maintainer approving it before being merged.

For content PRs, at least 24 hours must have passed since the creation of the PR before being merged. This can be bypassed by Head Maintainers if reasonable to do so.

If a PR may affect game admins (rules, rule clarifications, admin tooling, big balance changes, antags, etc) ensure a post has been made in #admin-reviews on discord.

  • If you are not sure, do it anyway.

  • If this is a very important or large PR, all Game Admins must be pinged in the post. (@Game Admins)

  • The scope of what affects admins is very broad currently because the Maintainer team is small.

  • After a minimum of two days:

    • If no one dissents, the PR can be merged (with Head Maintainer approval, as usual).
    • If there is dissent, the PR author must be notified on GitHub of people’s requests for changes and/or arguments against it. You do not need to put a ton of effort in summarizing people’s points, simply list opinions as “Maintainer opinion” and “Game Admin opinion”.
      • These opinions must be communicated in a neutral manner, even if you disagree with them.
    • This is the case even if only one person dissents.
    • Once addressed by the PR author, the process may be started again.
    • If a deadlock is reached where one or more people’s dissents cannot be resolved, a 24-hour-long poll must be made in the channel along with an @Head Game Admin ping.
    • At least 75% or more of voters must agree to it being merged before it does.
      • There is no veto power from any role in the project.
    • If less than 75% of people vote to merge the PR, it must be discussed again and the PR author must be notified.
    • If after another 48 hours no poll reaches 75% or more approvals, the PR may be closed.

Subpages